Adding TCN decoder. #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filangelos
reviewed
Aug 25, 2020
filangelos
reviewed
Aug 25, 2020
filangelos
reviewed
Aug 25, 2020
filangelos
reviewed
Aug 25, 2020
| # Perturb target. | ||
| y = torch.normal( # pylint: disable=no-member | ||
| mean=batch["player_future"][..., :2], | ||
| mean=target_mean, | ||
| std=torch.ones_like(batch["player_future"][..., :2]) * noise_level, # pylint: disable=no-member |
There was a problem hiding this comment.
use target_mean instead of batch["player_future"][..., :2]
There was a problem hiding this comment.
@Filangel it looks like I'm already using target_mean. Can you clarify?
filangelos
reviewed
Aug 25, 2020
|
|
||
| # Calculates loss (NLL). | ||
| loss = -torch.mean(log_prob - logabsdet, dim=0) # pylint: disable=no-member | ||
| if use_tcn: |
There was a problem hiding this comment.
the API for the decoder should be the same, regardless if it's an RNN or a TCN
There was a problem hiding this comment.
Can you clarify what you mean by this? By API, do you want the TCN decoder to similarly have a .inverse method, as the Autoregressive decoder does?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.